Improve formatting, error handling. Fixed typos.#600
Merged
Conversation
✅ Deploy Preview for superfile canceled.
|
5c711a8 to
03f5173
Compare
lazysegtree
commented
Feb 9, 2025
| - name: Test | ||
| run: go test ./... | ||
|
|
||
| - name: Test `go fmt` creates no diffs |
Collaborator
Author
There was a problem hiding this comment.
6675252 to
65c3951
Compare
lazysegtree
commented
Feb 9, 2025
| - name: golangci-lint | ||
| uses: golangci/golangci-lint-action@v6 | ||
| with: | ||
| version: v1.58 |
Collaborator
Author
There was a problem hiding this comment.
Ref : https://cicube.io/workflow-hub/golangci-golangci-lint-action/
Pinning a specific version is recommended to prevent unpredictable builds if a new version of golangci-lint introduces breaking changes.
Without with, latest version will be used
65c3951 to
c857330
Compare
44d39aa to
726199e
Compare
Collaborator
Author
lazysegtree
commented
Feb 10, 2025
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: 1.21 | ||
| go-version: 1.22.2 |
Collaborator
Author
There was a problem hiding this comment.
Updated it to match our version in go.mod
lazysegtree
commented
Feb 10, 2025
| } | ||
| } | ||
|
|
||
| package internal |
Collaborator
Author
There was a problem hiding this comment.
I dont know why this file is just recreated, But that what go fmt did.
lazysegtree
commented
Feb 10, 2025
|
|
||
| // Move file to trash can and can auto switch macos trash can or linux trash can | ||
| func trashMacOrLinux(src string) error { | ||
| var err error |
Collaborator
Author
There was a problem hiding this comment.
Removed code duplication here.
Collaborator
Author
|
@yorukot @BhagatHarsh I have finished the changes. Please review. |
Contributor
|
I don't know about the version updates. The formatting looks good, very thorough spellcheck 🚀 . |
yorukot
approved these changes
Feb 13, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Ran go fmt on all files to format them based on go standards.
Fixed a few typos
Improve go reportcard - https://goreportcard.com/report/github.com/yorukot/superfile
Fixed errors pointed by golangci lint report
Added go fmt check and golangci-lint check in github workflow
Its A+ now in this branch. (main branch is B - https://goreportcard.com/report/github.com/yorukot/superfile )