fix: hexbin example formatting + per-facet binning#556
Merged
gka merged 3 commits intoApr 27, 2026
Conversation
CI lint failed on prettier --check; routes/examples/**/*.svelte uses printWidth: 60 (overrides the default 100), so the Hexbin example tags needed to wrap. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Without this, a faceted plot shares one bin map across all facets and each panel renders the union. Mirrors Density's group-by-facet pattern. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
These belong as project-wide contributor tooling on main, not bundled with the hexbin feature. Moving to a separate PR off main. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
gka
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes for #552's
feat/hexbin-transformbranch:Prettier formatting — three Hexbin example files exceed the
printWidth: 60override forroutes/examples/**/*.svelte; ranpnpm format. Fixes the lint failure.Per-facet binning —
<Hexbin>inside a faceted plot was sharing one bin map across all facets, so each panel rendered the union of all data. Records are now partitioned by(fxVal, fyVal)before binning. MirrorsDensity.svelte:272-286, 441-497. New test intests/hexbin.test.svelte.ts.🤖 Generated with Claude Code