Skip to content

fix: hexbin example formatting + per-facet binning#556

Merged
gka merged 3 commits into
svelteplot:feat/hexbin-transformfrom
RobertFrenken:fix/hexbin-prettier
Apr 27, 2026
Merged

fix: hexbin example formatting + per-facet binning#556
gka merged 3 commits into
svelteplot:feat/hexbin-transformfrom
RobertFrenken:fix/hexbin-prettier

Conversation

@RobertFrenken

@RobertFrenken RobertFrenken commented Apr 26, 2026

Copy link
Copy Markdown
Contributor

Two fixes for #552's feat/hexbin-transform branch:

Prettier formatting — three Hexbin example files exceed the printWidth: 60 override for routes/examples/**/*.svelte; ran pnpm format. Fixes the lint failure.

Per-facet binning<Hexbin> inside a faceted plot was sharing one bin map across all facets, so each panel rendered the union of all data. Records are now partitioned by (fxVal, fyVal) before binning. Mirrors Density.svelte:272-286, 441-497. New test in tests/hexbin.test.svelte.ts.

🤖 Generated with Claude Code

CI lint failed on prettier --check; routes/examples/**/*.svelte uses
printWidth: 60 (overrides the default 100), so the Hexbin example tags
needed to wrap.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@netlify

netlify Bot commented Apr 26, 2026

Copy link
Copy Markdown

Deploy Preview for svelteplot ready!

Name Link
🔨 Latest commit 0d6e502
🔍 Latest deploy log https://app.netlify.com/projects/svelteplot/deploys/69eeab41210c7600088807aa
😎 Deploy Preview https://deploy-preview-556--svelteplot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Without this, a faceted plot shares one bin map across all facets and
each panel renders the union. Mirrors Density's group-by-facet pattern.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@RobertFrenken RobertFrenken changed the title chore: prettier-format hexbin example files fix: hexbin example formatting + per-facet binning Apr 26, 2026
These belong as project-wide contributor tooling on main, not bundled
with the hexbin feature. Moving to a separate PR off main.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@gka gka merged commit 340fbef into svelteplot:feat/hexbin-transform Apr 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants