fix: per-facet binning in Hexbin#557
Closed
RobertFrenken wants to merge 2 commits into
Closed
Conversation
CI lint failed on prettier --check; routes/examples/**/*.svelte uses printWidth: 60 (overrides the default 100), so the Hexbin example tags needed to wrap. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Without this, a faceted plot shares one bin map across all facets and each panel renders the union. Mirrors Density's group-by-facet pattern. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this,
<Hexbin>inside a faceted plot shares one bin map across all facets and each panel renders the union of all data. With this, records are partitioned by(fxVal, fyVal)before binning so each panel gets independent counts.Mirrors
Density.svelte:272-286(group-by-facet) and lines 441-497 (one corner-pair per facet for stable scale domains).Adds one test in
tests/hexbin.test.svelte.ts: group A clustered at one point → 1 bin; group B on a 3×3 grid → multiple bins; previously both panels would show the same union.Includes the prettier fix from #556 since it was already on this branch — that PR can merge first or get superseded.
🤖 Generated with Claude Code